feat: support querying at particular blocks #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.4.0Features
|
tlovell-sxt
force-pushed
the
feat/query-at-block
branch
2 times, most recently
from
9b1246c to
dfc075f
Compare
tlovell-sxt
changed the title
tlovell-sxt
force-pushed
the
feat/query-at-block
branch
from
dfc075f to
4b44ebf
Compare
Currently, both the rust and javascript clients perform queries at the latest block. We want to be able to perform queries at older blocks too. This is especially important for the chainlink use case, as chainlink's DON will perform the same query multiple times, expecting the same results from each run. To this end, this changes both clients and their underlying functions to accept an optional block hash.
tlovell-sxt
force-pushed
the
feat/query-at-block
branch
from
4b44ebf to
8502fbc
Compare
JayWhite2357
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, both the rust and javascript clients perform queries at the latest block. We want to be able to perform queries at older blocks too. This is especially important for the chainlink use case, as chainlink's DON will perform the same query multiple times, expecting the same results from each run. To this end, this changes both clients and their underlying functions to accept an optional block hash.
What changes are included in this PR?
Are these changes tested?
Only localy, no automated tests as these are difficult with the current stateful structure of the affected code.